I agree that this is painful (and you should remove it). We might want
to consider something like bors in the future.
James
···
On Fri, Mar 15, 2019 at 11:00 AM Thomas Scholtes <thomas@monadic.xyz> wrote:
If there are no objections I’m also going to remove the requirement to have the PR branch
based on master. I think it is unreasonable to have outside contributors continuously
rebasing or us clicking the “Update branch” button. (The latter also results in messed up
commit histories.)
Am Donnerstag, den 14.03.2019, 11:28 +0100 schrieb Thomas Scholtes:
> Hey everybody,
>
> Currently we can’t merge PRs from outside contributors because the Google Cloud Build is
> required but cannot not be run for forks because of security. I will mark the Google
> Cloud
> Build as not required anymore but mark the CircleCI build as required.
>
> We should only merge PRs that do not affect the tests, like doc fixes. (E.g.
> fixed Radicle by 0xflotus · Pull Request #560 · radicle-dev/radicle-alpha · GitHub). We should quickly migrate the CI build
> from Google to CircleCI to invite more outside collaboration.
>
> - Thomas
-----BEGIN PGP SIGNATURE-----
iHUEABYIAB0WIQRgWFKgZMmM9FzOXmGNIJdrjCQW0QUCXIuF2AAKCRCNIJdrjCQW
0camAQDurkw2MwnYoY0G8GMzVtNcHSo0yL8CNr4Uy92vh/kW2AD/SMKMKVzKR6bw
3TbO7ApEFtEKmPG5UlCXvCpLl/8CTAc=
=wxcz
-----END PGP SIGNATURE-----
Hey everybody,
Currently we can’t merge PRs from outside contributors because the Google Cloud Build is
required but cannot not be run for forks because of security. I will mark the Google Cloud
Build as not required anymore but mark the CircleCI build as required.
We should only merge PRs that do not affect the tests, like doc fixes. (E.g.
fixed Radicle by 0xflotus · Pull Request #560 · radicle-dev/radicle-alpha · GitHub). We should quickly migrate the CI build
from Google to CircleCI to invite more outside collaboration.
- Thomas
If there are no objections I’m also going to remove the requirement to have the PR branch
based on master. I think it is unreasonable to have outside contributors continuously
rebasing or us clicking the “Update branch” button. (The latter also results in messed up
commit histories.)
···
Am Donnerstag, den 14.03.2019, 11:28 +0100 schrieb Thomas Scholtes:
Hey everybody,
Currently we can’t merge PRs from outside contributors because the Google Cloud Build is
required but cannot not be run for forks because of security. I will mark the Google
Cloud
Build as not required anymore but mark the CircleCI build as required.
We should only merge PRs that do not affect the tests, like doc fixes. (E.g.
fixed Radicle by 0xflotus · Pull Request #560 · radicle-dev/radicle-alpha · GitHub). We should quickly migrate the CI build
from Google to CircleCI to invite more outside collaboration.
- Thomas